Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ carries the `SMPS` token and is the only rule `check-app-rules` excludes from
the comparison. It sits last in the file behind a marker that says so;
everything above that marker must match the source.

All 201 rules abaplint ships are named: 180 on, 21 off, each with its reason
All 212 rules abaplint ships are named: 190 on, 22 off, each with its reason
in a comment. **A rule is never left out of the file** — when an upgrade adds
one, add the key to `app-rules.json` and copy the block into all three
consumers: on if all three corpora pass, off with the reason if they do not.
Expand Down
17 changes: 16 additions & 1 deletion abaplint.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
// thing above the line that may differ. Everything else - what is checked,
// what is not, and why - is a joint decision of the three corpora.
//
// Every rule abaplint ships is listed: all 201. 180 are on, 21 are off and
// Every rule abaplint ships is listed: all 212. 190 are on, 22 are off and
// each says why. A rule is NEVER left out of the file. When an abaplint
// upgrade adds one, add the key: on if all three corpora pass, off with the
// reason if they do not. An unlisted rule reads as "nobody decided" rather
Expand Down Expand Up @@ -113,6 +113,11 @@
// (DATA temp9, DATA comps LIKE temp9) that cannot be inlined at all.
"prefer_inline": false,
"no_inline_in_optional_branches": false,
// The cast of the previous app into a variable of its own type, read on
// the next line (DATA(app) = CAST ...( client->get_app_prev( ) ).) -
// the rule wants one chained expression instead: 2 / 0 / 0 findings on
// 2.120.75. The sample names the app it reads back on purpose.
"prefer_inline_cast": false,
// --- off: the proposed rewrite does not activate ------------------
// The MOVE-CORRESPONDING statements left in the tree copy between two
// generic "TYPE any" field symbols. CORRESPONDING #( ) derives its type
Expand Down Expand Up @@ -423,6 +428,9 @@
"abstractEntity": "Z2UI5_"
},
// --- on, as shipped -----------------------------------------------
"abapdoc_html_tag": true,
"abapdoc_leading_at": true,
"abapdoc_parameter_names": true,
"add_test_attributes": true,
"aff_and_xml": true,
"align_pseudo_comments": true,
Expand All @@ -441,6 +449,7 @@
"cds_parser_error": true,
"chain_mainly_declarations": true,
"change_if_to_case": true,
"changing_sorted_line": true,
"check_comments": true,
"check_ddic": true,
"check_include": true,
Expand All @@ -458,6 +467,7 @@
"cyclomatic_complexity": true,
"db_operation_in_loop": true,
"definitions_top": true,
"delete_index_in_loop": true,
"description_empty": true,
"downport": true,
"dynpro_checks": true,
Expand All @@ -468,6 +478,7 @@
"exit_or_check": true,
"expand_macros": true,
"exporting": true,
"final_newline": true,
"fm_global_parameters_obsolete": true,
"forbidden_identifier": true,
"forbidden_pseudo_and_pragma": true,
Expand All @@ -487,6 +498,7 @@
"implicit_start_of_selection": true,
"index_completely_contained": true,
"inline_data_old_versions": true,
"inline_packed_computation": true,
"intf_referencing_clas": true,
"invalid_table_index": true,
"line_break_style": true,
Expand Down Expand Up @@ -538,6 +550,7 @@
"preferred_compare_operator": true,
"preferred_parameter_ignored": true,
"prefix_is_current_class": true,
"range_row_values": true,
"reduce_procedural_code": true,
"reduce_string_templates": true,
"redundant_conversion": true,
Expand All @@ -551,13 +564,15 @@
"short_case": true,
"sicf_consistency": true,
"slow_parameter_passing": true,
"sort_empty_key": true,
"space_before_colon": true,
"space_before_dot": true,
"sql_escape_host_variables": true,
"sql_value_conversion": true,
"start_at_tab": true,
"static_call_via_instance": true,
"strict_sql": true,
"subrc_after_assign": true,
"superfluous_value": true,
"sy_modification": true,
"sy_read_restriction": true,
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"devDependencies": {
"@abap2ui5/linter": "^0.8.5",
"@abap2ui5/linter-render": "^0.8.5",
"@abaplint/cli": "^2.120.73"
"@abaplint/cli": "^2.120.75"
},
"engines": {
"node": ">=22"
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-app-rules.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* check-app-rules — this repository's abaplint rules match the shared set.
*
* The shared set is `abap2UI5/abap2UI5`'s `.github/abaplint/app-rules.json`:
* 200 rules, everything except `object_naming`, which every repository sets
* 211 rules, everything except `object_naming`, which every repository sets
* for its own object prefixes. abap2UI5 is the SOURCE — it is where the rest
* of "how to write an abap2UI5 app" already lives (the build-an-app and
* view-chain-layout skills, docs/agents/building-apps.md, abap-check,
Expand Down
Loading