Conversation
…ironment markers Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
reviewed
Aug 15, 2022
pombredanne
approved these changes
Aug 15, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM ... but you need to fix the global issue first in environment_marker: Dict = {} before merging
TG1999
force-pushed
the
52
branch
2 times, most recently
from
August 15, 2022 18:38
c5d4423 to
1ea4b53
Compare
using a function argument with default mutable collection is a problem Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com