Skip to content

[DO NOT MERGE]Handle conflicts within in-memory advisories - #239

Closed
sbs2001 wants to merge 3 commits into
aboutcode-org:developfrom
sbs2001:add_constraint
Closed

sbs2001 wants to merge 3 commits into
aboutcode-org:developfrom
sbs2001:add_constraint

Conversation

@sbs2001

@sbs2001 sbs2001 commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Due to this we had to add 'is_vulnerable' in PackageRelatedVulnerability. This happened because we were unable to handle conflicts within in-memory advisories. This is fixed and the db constraints are changed too

sbs2001 added 3 commits August 4, 2020 15:30
Constraints are changed. Remove 'is_vulnerable' from
unique together of PackageRelatedVulnerability
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
@pombredanne

Copy link
Copy Markdown
Member

From a chat with @sbs2001 he does not want to merge that yet

@sbs2001 sbs2001 changed the title Handle conflicts within in-memory advisories [DO NOT MERGE]Handle conflicts within in-memory advisories Sep 11, 2020
@sbs2001 sbs2001 mentioned this pull request Sep 14, 2020
2 tasks
@sbs2001

sbs2001 commented Sep 14, 2020

Copy link
Copy Markdown
Collaborator Author

Closed in favour of #255

@sbs2001 sbs2001 closed this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants