Refactor importer_runner.py - #255
Merged
Merged
Conversation
sbs2001
changed the title
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
sbs2001
force-pushed
the
refactor_importer_runner
branch
from
September 14, 2020 13:20
99fd65b to
cc7659f
Compare
pombredanne
reviewed
Sep 15, 2020
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are alot of problems with importer_runner.py .
It has lots of redundant code.
It is expected to break once we use the new models from purl mixin.
Fixes #242 and superset of #239
TODOs :
Use a smaller fixture than the current
arch.jsonto reduce time to run testsHandle in memory conflicts
Signed-off-by: Shivam Sandbhor shivam.sandbhor@gmail.com