Add NVD importer - #243
Merged
Merged
Conversation
pombredanne
reviewed
Aug 11, 2020
pombredanne
approved these changes
Aug 11, 2020
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks!
See my reply inline
| ref_url = reference["url"] | ||
|
|
||
| # Skip references which exceed db constraints | ||
| if ref_id and len(ref_id) > 50: |
Member
There was a problem hiding this comment.
Ouch ... if you have a reference that crashes your schema, then your schema needs to be updated. Do not skip the data!
Member
There was a problem hiding this comment.
This would mean a model change IMHO
Collaborator
Author
There was a problem hiding this comment.
Let me first find the long ref id first.
I found some bugs after adding the length filter. Things may have changed
Collaborator
Author
There was a problem hiding this comment.
The extraction of reference ids from NVD is complicated, it contains lots of noise, I've skipped collecting the reference ids for now .
sbs2001
force-pushed
the
nvd_importer
branch
2 times, most recently
from
August 11, 2020 12:05
eb24a34 to
a0e75ba
Compare
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
sbs2001
force-pushed
the
nvd_importer
branch
from
September 17, 2020 10:40
a0e75ba to
6490983
Compare
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
sbs2001
force-pushed
the
nvd_importer
branch
from
September 17, 2020 10:46
6490983 to
1d69158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is based on #227.
Finally an importer for NVD.
Fixes #71