Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2024-2-21-Add_a_Payment_Link #142

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Conversation

oliverquinlan
Copy link
Contributor

Added documentation of payment link usability testing

PR Checklist

  • [ x] If you are proposing a new decision record document, used the right template for that
    - (ADR, decision-record, engagement, research)
  • [ x] Set yourself as the Assignee
  • [ x] Tag anyone you would like to review, or @forms-design or @forms-devs
  • [ x] Fill in the template below

What

Added documentation of the 'Add a payment link' journey usability testing.

How to review

Check the documentation represents the research.

Check for errors.

Who can review

Forms team

Added documentation of payment link usability testing
@oliverquinlan oliverquinlan requested a review from a team February 22, 2024 16:58
@oliverquinlan oliverquinlan self-assigned this Feb 22, 2024
@hannahkc
Copy link
Contributor

I think the filename needs .md added to it to make it a markdown file so it renders properly.

research/2024-2-21-Add_a_Payment_Link Outdated Show resolved Hide resolved
research/2024-2-21-Add_a_Payment_Link Outdated Show resolved Hide resolved
oliverquinlan and others added 5 commits February 27, 2024 13:17
Updated with new user research documentation template and required further information.
Corrected error in date
@oliverquinlan
Copy link
Contributor Author

@hannahkc Thanks for spotting those issues, have committed your changes.

Copy link
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (other than the file extension change Hannah mentioned!)

@oliverquinlan
Copy link
Contributor Author

@hannahkc I can't commit your suggestions as I changed them and the filename manually and then pushed the change, outdating yours. Please could you re-review.

Co-Authored-By: hannahkc <[email protected]>
hannahkc
hannahkc previously approved these changes Feb 28, 2024
Copy link
Contributor

@christophercameron-ixd christophercameron-ixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just 2 suggestions. Feel free to ignore

research/2024-2-21-Add_a_Payment_Link.md Outdated Show resolved Hide resolved
research/2024-2-21-Add_a_Payment_Link.md Outdated Show resolved Hide resolved
@oliverquinlan
Copy link
Contributor Author

Thanks @christophercameron-ixd have committed those. Please could you OK the review if you are happy with it.

Copy link
Contributor

@christophercameron-ixd christophercameron-ixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@oliverquinlan oliverquinlan merged commit 192fa87 into main Mar 1, 2024
@oliverquinlan oliverquinlan deleted the Add-a-Payment-Link branch March 1, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants