Repository navigation
ci: replace Windows cmd shell with PowerShell - #4812
Merged
lidavidm merged 1 commit intoSep 28, 2026
Merged
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
lidavidm
changed the title
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The PowerShell implementation preserves existing behavior and removes the remaining workflow cmd.exe usage.
Review effort: Balanced
Findings: None
What changed in this PR
Replaces the Windows driver-manager CI step’s cmd.exe usage with equivalent PowerShell commands, resolving #4269.
Changes:
- Constructs build paths using PowerShell.
- Preserves CMake configuration, build, installation, and error handling.
| File | Description |
|---|---|
.github/workflows/java.yml |
Migrates the Windows driver-manager build step to PowerShell. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lidavidm
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Replace the Windows driver-manager workflow step's
cmd.exeshell with PowerShell.Closes #4269.
AI assistance was used during development; the complete diff and test results were reviewed by the author.