Skip to content

ci: replace Windows cmd shell with PowerShell #4812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Sep 28, 2026
Merged

ci: replace Windows cmd shell with PowerShell #4812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,23 @@ jobs:
# I think static and shared conflict on Windows so build static separately
- name: Build driver manager (Windows)
if: matrix.os == 'Windows'
# TODO(https://github.com/apache/arrow-adbc/issues/4269): remove cmd.exe usage
shell: cmd # zizmor: ignore[misfeature]
shell: pwsh
run: |
cmake -G "Visual Studio 18 2026" -A x64 -DADBC_BUILD_SHARED=OFF -DADBC_BUILD_STATIC=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DADBC_DRIVER_MANAGER=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=%cd%\build\${{ matrix.vcpkg_arch }} -B %cd%\buildmanager %cd%\c || exit /B 1
cmake --build %cd%\buildmanager --config Debug --target install --verbose -j || exit /B 1
$buildDir = Join-Path $PWD.Path 'buildmanager'
$installPrefix = Join-Path $PWD.Path 'build/${{ matrix.vcpkg_arch }}'
$sourceDir = Join-Path $PWD.Path 'c'
cmake -G 'Visual Studio 18 2026' -A x64 `
'-DADBC_BUILD_SHARED=OFF' `
'-DADBC_BUILD_STATIC=ON' `
'-DCMAKE_VERBOSE_MAKEFILE=ON' `
'-DADBC_DRIVER_MANAGER=ON' `
'-DCMAKE_BUILD_TYPE=RelWithDebInfo' `
"-DCMAKE_INSTALL_PREFIX=$installPrefix" `
-B $buildDir `
$sourceDir
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
cmake --build $buildDir --config Debug --target install --verbose -j
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }

- name: Build JNI artifacts
run: |
Expand Down
Loading