Repository navigation
HDDS-17720. Fork CI Status should not cancel pending - #11955
Merged
Merged
Conversation
Contributor
Author
|
Thanks @smengcl for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fork CI Statusworkflow was created withcancel-in-progress: false, but new runs still cancel any previous one still pending, example:This is the default concurrency behavior. However, it can lead to starving, since the new run is added to the end of the queue.
This change allows at most 100 jobs to get queued before cancelling/rejecting. (There is no config value between 1 and 100...)
https://issues.apache.org/jira/browse/HDDS-17720
How was this patch tested?
zizmor: https://github.com/adoroszlai/ozone/actions/runs/42107321525
allowlist: https://github.com/adoroszlai/ozone/actions/runs/42107321658