Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix shard_batch_size = 0 support and re-add the cycle count print for execution #163

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix: Fix shard_batch_size = 0 support and re-add the cycle count print for execution #163

merged 2 commits into from
Aug 26, 2024

Conversation

wwared
Copy link
Contributor

@wwared wwared commented Aug 26, 2024

Fixes #160

Reintroduces a cycle count for execution-only runs so we can fix the LC repo's cycle-count-regression CI check. The print is added only to run_untraced, which is called by client.execute(...).run().

Example output:

2024-08-26T17:31:55.638116Z  INFO execute: clk = 0 pc = 0x200d04
2024-08-26T17:31:55.638896Z  INFO execute: summary: cycles=7157
2024-08-26T17:31:55.638945Z  INFO execute: close time.busy=1.45ms time.idle=2.30µs

@huitseeker @wwared
refactor: reinstate shard_batch_size
aca9eed 
Restore the ability to run the entire process in one chunk by setting `SHARD_BATCH_SIZE` to `0`.

Fixes #160
@wwared wwared force-pushed the fix-shard-batch-size-0 branch from ba0f9cf to 4fb6305 Compare August 26, 2024 17:32
huitseeker
huitseeker approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@wwared wwared enabled auto-merge (squash) August 26, 2024 17:34
@wwared wwared merged commit d392acc into dev Aug 26, 2024
8 checks passed
@wwared wwared deleted the fix-shard-batch-size-0 branch August 26, 2024 18:07
@samuelburnham samuelburnham mentioned this pull request Aug 26, 2024
Merged
@wwared wwared mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@storojs72 storojs72 Awaiting requested review from storojs72

@samuelburnham samuelburnham Awaiting requested review from samuelburnham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-add SHARD_BATCH_SIZE=0 support
2 participants
@wwared @huitseeker