Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix shard_batch_size = 0 support and re-add the cycle count print for execution #163

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix: Fix shard_batch_size = 0 support and re-add the cycle count print for execution #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca9eed
refactor: reinstate shard_batch_size
huitseeker Jun 15, 2024
4fb6305
feat: Print summary at end of execution
wwared Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/runtime/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,6 +1037,10 @@ impl<'a> Runtime<'a> {
self.emit_events = false;
self.print_report = true;
while !self.execute()? {}

// Print the summary.
tracing::info!("summary: cycles={}", self.state.global_clk,);

Ok(())
}

Expand Down
7 changes: 6 additions & 1 deletion prover/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,12 @@ impl SphinxProver {
);

let mut reduce_proofs = Vec::new();
let shard_batch_size = opts.recursion_opts.shard_batch_size;
// We want the ability to set SHARD_BATCH_SIZE to 0 to run everything in one chunk
let shard_batch_size = if opts.recursion_opts.shard_batch_size > 0 {
opts.recursion_opts.shard_batch_size
} else {
usize::MAX
};
for inputs in core_inputs.chunks(shard_batch_size) {
let proofs = inputs
.into_par_iter()
Expand Down