Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces #4174

Merged
merged 54 commits into from
Dec 17, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jul 2, 2024

Change Summary

Add switchport 'tap' and 'tool' mode config to the interfaces

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add schema, template and tests for switchport.tap and switchport.tool in interfaces.

How to test

Molecule test added. Test in EOS CLI.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Jul 2, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4174
# Activate the virtual environment
source test-avd-pr-4174/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_tap_tool#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_tap_tool --force
# Optional: Install AVD examples
cd test-avd-pr-4174
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 2, 2024
@Shivani-gslab Shivani-gslab force-pushed the switchport_tap_tool branch from 4737324 to 9cc2279 Compare July 2, 2024 10:39
@Shivani-gslab Shivani-gslab force-pushed the switchport_tap_tool branch from 0dbd7c7 to 2302af9 Compare July 2, 2024 11:22
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 15, 2024 12:05
@Shivani-gslab Shivani-gslab requested review from a team as code owners July 15, 2024 12:05
@Shivani-gslab Shivani-gslab marked this pull request as draft July 21, 2024 17:24
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 22, 2024 12:38
@Shivani-gslab Shivani-gslab marked this pull request as draft July 22, 2024 13:24
@Shivani-gslab Shivani-gslab marked this pull request as draft December 10, 2024 05:59
@Shivani-gslab Shivani-gslab marked this pull request as ready for review December 10, 2024 11:17
@Shivani-gslab Shivani-gslab requested a review from gmuloc December 10, 2024 11:17
Shivani-gslab and others added 2 commits December 12, 2024 14:56
Co-authored-by: Guillaume Mulocher <[email protected]>
@Shivani-gslab Shivani-gslab marked this pull request as draft December 16, 2024 09:30
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot for this PR!

@Shivani-gslab Shivani-gslab marked this pull request as ready for review December 16, 2024 16:26
@gmuloc gmuloc merged commit 7b21968 into aristanetworks:devel Dec 17, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants