-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces #4174
Merged
gmuloc
merged 54 commits into
aristanetworks:devel
from
Shivani-gslab:switchport_tap_tool
Dec 17, 2024
Merged
Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces #4174
gmuloc
merged 54 commits into
aristanetworks:devel
from
Shivani-gslab:switchport_tap_tool
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4174
# Activate the virtual environment
source test-avd-pr-4174/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_tap_tool#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_tap_tool --force
# Optional: Install AVD examples
cd test-avd-pr-4174
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Jul 2, 2024
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
July 2, 2024 10:39
4737324
to
9cc2279
Compare
4 tasks
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
July 2, 2024 11:22
0dbd7c7
to
2302af9
Compare
MaheshGSLAB
reviewed
Jul 10, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_cli_config_gen/intended/configs/port-channel-interfaces.cfg
Outdated
Show resolved
Hide resolved
Shivani-gslab
commented
Jul 12, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
July 12, 2024 13:09
06cbda0
to
8e90dbc
Compare
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Jul 18, 2024
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
July 22, 2024 11:01
0c2451f
to
bb0d566
Compare
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
July 22, 2024 11:01
bb0d566
to
7e79986
Compare
for more information, see https://pre-commit.ci
MaheshGSLAB
approved these changes
Dec 9, 2024
laxmikantchintakindi
approved these changes
Dec 9, 2024
gmuloc
reviewed
Dec 9, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
December 10, 2024 07:23
52a1079
to
0b95c1d
Compare
gmuloc
reviewed
Dec 11, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Mulocher <[email protected]>
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
December 12, 2024 09:27
32cfea1
to
6124820
Compare
gmuloc
requested changes
Dec 12, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_tap_tool
branch
from
December 16, 2024 13:01
24f063a
to
79364ae
Compare
gmuloc
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks a lot for this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add switchport 'tap' and 'tool' mode config to the interfaces
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Add schema, template and tests for
switchport.tap
andswitchport.tool
in interfaces.How to test
Molecule test added. Test in EOS CLI.
Checklist
User Checklist
Repository Checklist