Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(eos_cli_config_gen): Restructured the eos_cli_config_gen molecule host vars for ethernet, port-channel and vlan interfaces #4697

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Nov 7, 2024

Change Summary

Restructured the eos_cli_config_gen molecule host vars for ethernet and port-channel interfaces

Related Issue(s)

Fixes #https://github.com/aristanetworks/avd-internal/issues/171

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Nov 7, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4697
# Activate the virtual environment
source test-avd-pr-4697/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@move_ethernet_port_channel#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,move_ethernet_port_channel --force
# Optional: Install AVD examples
cd test-avd-pr-4697
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 7, 2024
@Shivani-gslab Shivani-gslab changed the title CI(eos_cli_config_gen): Restructured the eos_cli_config_gen molecule host vars for ethernet and post-channel interfaces CI(eos_cli_config_gen): Restructured the eos_cli_config_gen molecule host vars for ethernet and port-channel interfaces Nov 7, 2024
@Shivani-gslab Shivani-gslab changed the title CI(eos_cli_config_gen): Restructured the eos_cli_config_gen molecule host vars for ethernet and port-channel interfaces CI(eos_cli_config_gen): Restructured the eos_cli_config_gen molecule host vars for ethernet, port-channel and vlan interfaces Nov 7, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Shivani-gslab Shivani-gslab force-pushed the move_ethernet_port_channel branch from 12a0d26 to 60cb150 Compare November 8, 2024 10:27
Copy link

github-actions bot commented Nov 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review November 8, 2024 14:31
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners November 8, 2024 14:31
@ClausHolbechArista
Copy link
Contributor

Please update the description if it is ready for review. Or set as draft if not.

@Shivani-gslab Shivani-gslab force-pushed the move_ethernet_port_channel branch from f90e7d7 to 9c8389a Compare November 8, 2024 15:27
Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible - please just fix the name of the tracking object under Eth66

Copy link

@ClausHolbechArista ClausHolbechArista merged commit 9927023 into aristanetworks:devel Nov 11, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: CI(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants