-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Support Frame Chunking for tasks #77
Open
Ahuge
wants to merge
5
commits into
aws-deadline:mainline
Choose a base branch
from
ArchPlatform:ah/feature/frame-chunking-workflow
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat!: Support Frame Chunking for tasks #77
Ahuge
wants to merge
5
commits into
aws-deadline:mainline
from
ArchPlatform:ah/feature/frame-chunking-workflow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now matches the other new DCC naming scheme Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
This happens via a FrameStart, FrameEnd, ChunkSize and 2 internal parameters that are just calculations based on the previous ones. We've also reorganized some of the code to hopefully isolate it against future changes. Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
Ahuge
force-pushed
the
ah/feature/frame-chunking-workflow
branch
from
December 11, 2024 16:51
ed8d7f4
to
b67edc5
Compare
Quality Gate failedFailed conditions |
eherozhao
reviewed
Dec 18, 2024
dcProperties.jobAttachments.autoDetectedInputFiles.set(detectedItemsList); | ||
} | ||
|
||
function _generateFontReferences() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems out of the scope of this PR. Could we only have Chunking change in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
There can be a high overhead for launching AfterEffects (aerender) for each frame and for short renders, this overhead can be more than half of the entire render time for the job.
What was the solution? (How)
This solution uses a clever taskParameterDefinitions range function to implement frame chunking from the
OpenJD-Specifications
wiki: Search for FrameEndMinusOneWhat is the impact of this change?
A new UI field Frames Per Task in Job-Specific Settings
That field now controls the chunk size for each task.
This modifies the JobTemplate parameters with two new "calculated" parameters
FrameStartPlusChunkSizeMinusOne
andFrameEndMinusOne
which are calculated in the submitter and passed as parameters to the template.How was this change tested?
We ran jobs through the three Comp Submission workflows: "Submit One Comp", "Submit Entire Queue As One Job", "Submit Entire Queue As Separate Jobs".
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Was this change documented?
Is this a breaking change?
Yes
Runtime Data
I have some runtime metrics from a naive aerender (1 frame per task) workflow and a chunked aerender workflow:
Naive Submission:
My Chunked Submission:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.