-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13829] Add check for empty array when deleting unassigned items #11927
Merged
BTreston
merged 3 commits into
main
from
ac/pm-13829-delete-unnassigned-items-from-item-modal
Nov 13, 2024
Merged
[PM-13829] Add check for empty array when deleting unassigned items #11927
BTreston
merged 3 commits into
main
from
ac/pm-13829-delete-unnassigned-items-from-item-modal
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11927 +/- ##
=======================================
Coverage 33.41% 33.42%
=======================================
Files 2841 2841
Lines 89008 89008
Branches 16979 16979
=======================================
+ Hits 29744 29751 +7
+ Misses 56927 56920 -7
Partials 2337 2337 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
gbubemismith
approved these changes
Nov 13, 2024
BTreston
deleted the
ac/pm-13829-delete-unnassigned-items-from-item-modal
branch
November 13, 2024 19:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13829
📔 Objective
This PR expands the check on unassigned items to include an empty array.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes