Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16932] Fix timeout when desktop app is not started #12799

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jan 10, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16932

📔 Objective

Prevents a 5 second wait period, that is needed for the legacy biometrics protocol. Since the status is re-checked every second, timing out means it will temporarily be unavailable, and if the desktop app starts later, it will be enabled again.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner January 10, 2025 12:45
@quexten quexten changed the title Fix timeout when desktop app is not started [PM-16932] Fix timeout when desktop app is not started Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Logo
Checkmarx One – Scan Summary & Details4f3209b4-8e2d-4248-850d-c500e1237d7b

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (6872100) to head (aabbb42).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12799      +/-   ##
==========================================
- Coverage   34.14%   34.13%   -0.01%     
==========================================
  Files        2936     2936              
  Lines       90439    90442       +3     
  Branches    16990    16991       +1     
==========================================
- Hits        30878    30873       -5     
- Misses      57103    57111       +8     
  Partials     2458     2458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mzieniukbw
mzieniukbw previously approved these changes Jan 10, 2025
Base automatically changed from km/fix-biometrics-browser-prompt to main January 13, 2025 08:29
@quexten quexten dismissed mzieniukbw’s stale review January 13, 2025 08:29

The base branch was changed.

@quexten quexten requested a review from mzieniukbw January 13, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants