Skip to content

Feat/cstm cpc 1013 add pet weight #413

Feat/cstm cpc 1013 add pet weight

Feat/cstm cpc 1013 add pet weight #413

Triggered via pull request October 22, 2023 23:08
Status Success
Total duration 10m 50s
Artifacts 1
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

qodana_code_quality.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

280 warnings and 76 notices
Possibly blocking call in non-blocking context: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/RoleFilter.java#L58
Possibly blocking call in non-blocking context could lead to thread starvation
Possibly blocking call in non-blocking context: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/IsUserFilter.java#L56
Possibly blocking call in non-blocking context could lead to thread starvation
Nullability and data flow problems: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/IsUserFilter.java#L49
Unboxing of `exchange.getAttribute("whitelisted")` may produce `NullPointerException`
Nullability and data flow problems: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/RoleFilter.java#L49
Unboxing of `exchange.getAttribute("whitelisted")` may produce `NullPointerException`
Integer multiplication or shift implicitly cast to 'long': customers-service-reactive/src/main/java/com/petclinic/customersservice/business/OwnerServiceImpl.java#L104
pageable.getPageNumber() \* pageable.getPageSize(): integer multiplication implicitly cast to long
Integer multiplication or shift implicitly cast to 'long': customers-service-reactive/src/main/java/com/petclinic/customersservice/business/OwnerServiceImpl.java#L110
pageable.getPageNumber() \* pageable.getPageSize(): integer multiplication implicitly cast to long
Lombok annotations: api-gateway/src/main/java/com/petclinic/bffapigateway/exceptions/InventoryNotFoundException.java#L8
Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '(callSuper=false)' to your type.
Lombok annotations: api-gateway/src/main/java/com/petclinic/bffapigateway/exceptions/ExistingVetNotFoundException.java#L7
Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '(callSuper=false)' to your type.
Lombok annotations: api-gateway/src/main/java/com/petclinic/bffapigateway/exceptions/ProductListNotFoundException.java#L6
Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '(callSuper=false)' to your type.
Lombok annotations: api-gateway/src/main/java/com/petclinic/bffapigateway/exceptions/InvalidInputsInventoryException.java#L7
Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '(callSuper=false)' to your type.
Lombok annotations: api-gateway/src/main/java/com/petclinic/bffapigateway/exceptions/GenericHttpException.java#L14
Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object. If this is intentional, add '(callSuper=false)' to your type.
@NotNull/@Nullable problems: customers-service-reactive/src/main/java/com/petclinic/customersservice/data/OwnerRepo.java#L13
Not annotated method overrides method annotated with @NonNullApi
Redundant type cast: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/IsUserFilter.java#L82
Casting `exchange.getAttribute(...)` to `TokenResponseDTO` is redundant
Redundant type cast: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/RoleFilter.java#L86
Casting `exchange.getAttribute(...)` to `TokenResponseDTO` is redundant
'size() == 0' can be replaced with 'isEmpty()': auth-service/src/main/java/com/petclinic/authservice/businesslayer/UserServiceImpl.java#L129
`gatewaySubdomain.length() > 0` can be replaced with '!gatewaySubdomain.isEmpty()'
Invalid YAML configuration: auth-service/src/main/resources/application.yml#L18
Cannot resolve configuration property 'default-admin.username'
Invalid YAML configuration: inventory-service/src/main/resources/application.yml#L17
Cannot resolve configuration property 'de.flapdoodle.mongodb.embedded.version'
Invalid YAML configuration: auth-service/src/main/resources/application.yml#L19
Cannot resolve configuration property 'default-admin.password'
Invalid YAML configuration: billing-service/src/main/resources/application.yml#L25
Cannot resolve configuration property 'app.customers-service.host'
Invalid YAML configuration: billing-service/src/main/resources/application.yml#L23
Cannot resolve configuration property 'app.vet-service.port'
Invalid YAML configuration: auth-service/src/main/resources/application.yml#L25
Cannot resolve configuration property 'gateway.subdomain'
Invalid YAML configuration: visits-service-new/src/main/resources/application.yml#L26
Cannot resolve configuration property 'de.flapdoodle.mongodb.embedded.version'
Invalid YAML configuration: billing-service/src/main/resources/application.yml#L22
Cannot resolve configuration property 'app.vet-service.host'
Invalid YAML configuration: customers-service-reactive/src/main/resources/application.yml#L6
Cannot resolve configuration property 'server.logging.level.root'
Invalid YAML configuration: billing-service/src/main/resources/application.yml#L26
Cannot resolve configuration property 'app.customers-service.port'
Invalid YAML configuration: customers-service-reactive/src/main/resources/application.yml#L7
Cannot resolve configuration property 'server.logging.level.com.petclinic'
Call to 'printStackTrace()': vet-service/src/main/java/com/petclinic/vet/servicelayer/DataSetupService.java#L337
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Rethrower.java#L36
Call to `printStackTrace()` should probably be replaced with more robust logging
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/dtos/Auth/UserPasswordAndTokenRequestModel.java#L9
Unused import `import org.springframework.validation.annotation.Validated;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/dtos/Vets/BadgeResponseDTO.java#L7
Unused import `import org.springframework.core.io.ClassPathResource;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/education/EducationServiceImpl.java#L6
Unused import `import com.petclinic.vet.exceptions.InvalidInputException;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/business/PetService.java#L4
Unused import `import com.petclinic.customersservice.presentationlayer.PetRequestDTO;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/data/PetRepo.java#L3
Unused import `import com.petclinic.customersservice.presentationlayer.PetResponseDTO;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/badges/BadgeRequestDTO.java#L3
Unused import `import com.petclinic.vet.dataaccesslayer.badges.BadgeTitle;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/badges/BadgeResponseDTO.java#L8
Unused import `import org.springframework.core.io.ClassPathResource;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/InventoryServiceClient.java#L15
Unused import `import org.springframework.http.HttpStatus;`
Unused import: auth-service/src/main/java/com/petclinic/authservice/Util/Configuration/Security/SecurityConfig.java#L16
Unused import `import org.springframework.security.core.userdetails.UserDetails;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/InventoryServiceClient.java#L4
Unused import `import com.petclinic.bffapigateway.dtos.Inventory.InventoryResponseDTO;`
Unused import: vet-service/src/main/java/com/petclinic/vet/exceptions/GlobalControllerExceptionHandler.java#L20
Unused import `import org.springframework.web.context.request.WebRequest;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/badges/BadgeRequestDTO.java#L8
Unused import `import org.springframework.core.io.ClassPathResource;`
Unused import: auth-service/src/main/java/com/petclinic/authservice/presentationlayer/User/TokenResponseDTO.java#L3
Unused import `import com.petclinic.authservice.datalayer.roles.Role;`
Unused import: vet-service/src/main/java/com/petclinic/vet/dataaccesslayer/badges/Badge.java#L4
Unused import `import org.springframework.core.io.ClassPathResource;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/InventoryServiceClient.java#L6
Unused import `import com.petclinic.bffapigateway.dtos.Inventory.ProductRequestDTO;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/presentationlayer/PetTypeRequestDTO.java#L4
Unused import `import com.fasterxml.jackson.annotation.JsonIgnoreProperties;`
Unused import: vet-service/src/main/java/com/petclinic/vet/presentationlayer/VetController.java#L26
Unused import `import org.springframework.core.io.ByteArrayResource;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/dtos/Vets/PhotoDetails.java#L3
Unused import `import com.fasterxml.jackson.annotation.JsonIgnore;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Rethrower.java#L10
Unused import `import java.security.Provider;`
Unused import: auth-service/src/main/java/com/petclinic/authservice/Util/Configuration/Security/SecurityConfig.java#L20
Unused import `import org.springframework.security.provisioning.InMemoryUserDetailsManager;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/VetsServiceClient.java#L14
Unused import `import org.springframework.util.LinkedMultiValueMap;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/InventoryServiceClient.java#L7
Unused import `import com.petclinic.bffapigateway.dtos.Inventory.ProductResponseDTO;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/VetAverageRatingDTO.java#L3
Unused import `import com.petclinic.vet.presentationlayer.VetRequestDTO;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/ratings/RatingServiceImpl.java#L12
Unused import `import com.petclinic.vet.presentationlayer.VetRequestDTO;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/config/GlobalExceptionHandler.java#L8
Unused import `import org.springframework.web.bind.MethodArgumentNotValidException;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Rethrower.java#L13
Unused import `import java.util.function.Supplier;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/dtos/Auth/Register.java#L4
Unused import `import com.petclinic.bffapigateway.dtos.CustomerDTOs.OwnerResponseDTO;`
Unused import: auth-service/src/main/java/com/petclinic/authservice/security/JwtTokenUtil.java#L10
Unused import `import org.springframework.boot.autoconfigure.security.oauth2.resource.OAuth2ResourceServerPropertie...`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/business/PetTypeService.java#L4
Unused import `import com.petclinic.customersservice.presentationlayer.OwnerResponseDTO;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/VetsServiceClient.java#L4
Unused import `import com.petclinic.bffapigateway.exceptions.ExistingRatingNotFoundException;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Annotations/SecuredEndpoint.java#L5
Unused import `import org.springframework.web.bind.annotation.*;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/DataSetupService.java#L12
Unused import `import com.petclinic.vet.util.EntityDtoUtil;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/VetsServiceClient.java#L15
Unused import `import org.springframework.util.MultiValueMap;`
Unused import: vet-service/src/main/java/com/petclinic/vet/dataaccesslayer/PhotoRepository.java#L4
Unused import `import org.springframework.stereotype.Repository;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/InventoryServiceClient.java#L5
Unused import `import com.petclinic.bffapigateway.dtos.Inventory.InventoryRequestDTO;`
Unused import: auth-service/src/main/java/com/petclinic/authservice/Util/Configuration/Security/SecurityConfig.java#L15
Unused import `import org.springframework.security.core.userdetails.User;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/dtos/Vets/BadgeResponseDTO.java#L8
Unused import `import org.springframework.core.io.Resource;`
Unused import: inventory-service/src/main/java/com/petclinic/inventoryservice/presentationlayer/InventoryRequestDTO.java#L3
Unused import `import com.petclinic.inventoryservice.datalayer.Inventory.InventoryType;`
Unused import: inventory-service/src/main/java/com/petclinic/inventoryservice/presentationlayer/InventoryResponseDTO.java#L3
Unused import `import com.petclinic.inventoryservice.datalayer.Inventory.InventoryType;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/business/OwnerService.java#L6
Unused import `import org.springframework.web.bind.annotation.RequestParam;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/presentationlayer/PetTypeController.java#L4
Unused import `import com.petclinic.customersservice.data.PetType;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/CustomersServiceClient.java#L14
Unused import `import org.springframework.web.bind.annotation.RequestParam;`
Unused import: api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/IsUserFilter.java#L10
Unused import `import com.petclinic.bffapigateway.utils.Security.Annotations.SecuredEndpoint;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/business/PetTypeServiceImpl.java#L5
Unused import `import com.petclinic.customersservice.presentationlayer.OwnerResponseDTO;`
Unused import: vet-service/src/main/java/com/petclinic/vet/util/EntityDtoUtil.java#L18
Unused import `import com.petclinic.vet.dataaccesslayer.Specialty;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/badges/BadgeResponseDTO.java#L9
Unused import `import org.springframework.core.io.Resource;`
Unused import: vet-service/src/main/java/com/petclinic/vet/util/EntityDtoUtil.java#L14
Unused import `import com.petclinic.vet.dataaccesslayer.Photo;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/business/PetServiceImpl.java#L5
Unused import `import com.petclinic.customersservice.presentationlayer.PetRequestDTO;`
Unused import: vet-service/src/main/java/com/petclinic/vet/servicelayer/badges/BadgeServiceImpl.java#L10
Unused import `import org.springframework.core.io.ByteArrayResource;`
Unused import: customers-service-reactive/src/main/java/com/petclinic/customersservice/presentationlayer/OwnerController.java#L7
Unused import `import org.springframework.beans.factory.annotation.Autowired;`
Unused import: billing-service/src/main/java/com/petclinic/billing/util/EntityDtoUtil.java#L4
Unused import `import com.petclinic.billing.businesslayer.RequestContextAdd;`
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Artifacts

Produced during runtime
Name Size
gradle-coverage-data.zip Expired
4.9 MB