Feat/readme

[devlancer412]

No description provided.

[devlancer412]

@chimera-defi Could you check readme for deploy and verify tasks?

[chimera-defi]

hmm looks like running the underlying with tags minter seems to err out

$ npx hardhat deploy --network localhost --tags minter
TypeError: Cannot read properties of undefined (reading 'address') at /04_minter.ts:24:23

same with payment splitter.
wsgeth and sgeth seem to deploy properly and addresses get reused correctly though.

[devlancer412]

It's because deploy script uses second wallet address as mutisig address

SharedDeposit/deploy/03_paymentSplitter.ts

Line 10 in 3ca0fbb

const splitterAddresses = [accounts.deployer.address, accounts.multiSig.address, wsgEth.target];

SharedDeposit/hardhat.config.ts

Line 147 in 3ca0fbb

namedAccounts: {

There are two cases can fix this.

• don't use named account for deploy script and use static address(but named accounts provides some benefits for testing and automation).
• we can use mnemonic or can use multiple private keys for deployment in hardhat config

[chimera-defi]

hmm, lets do what we used to do in hardhat config and use the default anvil private key for the default address? and make it clear what is expected from the script user to get it to work?

on mainnet, we wont have the priv key of the multisig as itll be a gnosis safe, but we can execute txs through it, and ideally we deploy everything first, then transfer anything needed to the multisig

[devlancer412]

yeah. maybe, let me change multiSig address to constant

[devlancer412]

Used constant multisig address. Please check deploy script now. @chimera-defi

[devlancer412]

@chimera-defi Could you kindly check tg?