-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/readme #36
Merged
Merged
Feat/readme #36
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import {task} from "hardhat/config"; | ||
import {HardhatRuntimeEnvironment} from "hardhat/types"; | ||
|
||
task("upload", "Verifies deployed contract") | ||
.addParam("contract", "Name of contract") | ||
.setAction(async (taskArgs, hre) => { | ||
const contractName = taskArgs.contract; | ||
const contract = await getContractSource(hre, contractName); | ||
const networkName = hre.network.name; | ||
const artifacts = require(`../deployments/${networkName}/${contractName}.json`); | ||
//eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
const constructorArguments = (artifacts.args as any[]) || []; | ||
const address = artifacts.address as string; | ||
|
||
await hre.run("verify:verify", { | ||
address, | ||
constructorArguments, | ||
contract, | ||
}); | ||
}); | ||
|
||
task("upload:batch", "Verifies deployed contracts") | ||
.addParam("contracts", "Names of contracts") | ||
.setAction(async (taskArgs, hre) => { | ||
const rawInput = taskArgs.contracts as string; | ||
const contractNames = rawInput.split(",") as string[]; | ||
for (const contractName of contractNames) { | ||
const contract = await getContractSource(hre, contractName); | ||
const networkName = hre.network.name; | ||
const artifacts = require(`../deployments/${networkName}/${contractName}.json`); | ||
//eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
const constructorArguments = (artifacts.args as any[]) || []; | ||
const address = artifacts.address as string; | ||
try { | ||
await hre.run("verify:verify", { | ||
address, | ||
constructorArguments, | ||
contract, | ||
}); | ||
} catch (error) { | ||
console.error(error); | ||
} | ||
} | ||
}); | ||
|
||
const getContractSource = async (hre: HardhatRuntimeEnvironment, contractName: string): Promise<string | undefined> => { | ||
const sourceNames = await hre.artifacts.getAllFullyQualifiedNames(); | ||
|
||
for (let i = 0; i < sourceNames.length; i++) { | ||
const parts = sourceNames[i].split(":"); | ||
if (parts[1] === contractName) { | ||
return sourceNames[i]; | ||
} | ||
} | ||
return undefined; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm looks like running the underlying with tags minter seems to err out
same with payment splitter.
wsgeth and sgeth seem to deploy properly and addresses get reused correctly though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because deploy script uses second wallet address as mutisig address
SharedDeposit/deploy/03_paymentSplitter.ts
Line 10 in 3ca0fbb
SharedDeposit/hardhat.config.ts
Line 147 in 3ca0fbb
There are two cases can fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, lets do what we used to do in hardhat config and use the default anvil private key for the default address? and make it clear what is expected from the script user to get it to work?
on mainnet, we wont have the priv key of the multisig as itll be a gnosis safe, but we can execute txs through it, and ideally we deploy everything first, then transfer anything needed to the multisig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. maybe, let me change multiSig address to constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used constant multisig address. Please check deploy script now. @chimera-defi