Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mmcoralogix
Copy link

updated readme. no other changes

updated readme
@mmcoralogix mmcoralogix requested a review from a team as a code owner July 6, 2023 10:34
@royfur royfur requested a review from daidokoro July 6, 2023 13:40
@@ -14,7 +14,7 @@ In order to configure Fluentbit as a sidecar container in an ECS Fargate task, y

When using the Fluentbit for AWS container image, you need to embed your configuration file in the Image itself. This is because the Fluentbit for AWS image already has a default configuration that is required for the integration to work. When we embed our configuration file in the image, it runs alongside the default configuration.

Once the your fluentbit image is created it needs to be pushed to ECR or any other publicy accessible container registry.
Once your fluentbit image is created it needs to be pushed to ECR or any other publically accessible container registry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once your fluentbit image is created it needs to be pushed to ECR or any other publically accessible container registry.
Once your fluentbit image is created it needs to be pushed to ECR or any other publicly accessible container registry.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just a minor change here.

coralogix-concourse added a commit that referenced this pull request Nov 28, 2023
coralogix-concourse added a commit that referenced this pull request Jan 4, 2024
…ed values in integrationType * align cargo.toml version with template version * Update CHANGELOG.md * Update Cargo.toml version * align cargo.toml version with template version --------- Co-authored-by: Concourse <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ mmcoralogix
❌ ryantanjunming
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants