Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: mpi hdf5 #902

Merged
merged 10 commits into from
Jan 7, 2025
Merged

refactor!: mpi hdf5 #902

merged 10 commits into from
Jan 7, 2025

Conversation

drodarie
Copy link
Contributor

@drodarie drodarie commented Dec 17, 2024

Describe the work done

Refactor JobPool id creation
Forward MPI comm to the recognizes static method.

BREAKING CHANGES: bsb compile with clear now clears everything in the Storage

Needs dbbs-lab/bsb-hdf5#36

List which issues this resolves:

Closes #893 #836 #388

Tasks

  • Added tests

@drodarie drodarie requested a review from Helveg December 17, 2024 12:07
@drodarie drodarie self-assigned this Dec 17, 2024
@github-actions github-actions bot added the fix label Dec 17, 2024
Copy link
Contributor

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather introduce the rule that every static method is passed the communicator. Passing the lock around feels too specific to this use case, the communicator is probably the real missing piece of the puzzle?

@drodarie drodarie changed the title fix: mpi hdf5 refactor!: mpi hdf5 Dec 29, 2024
@drodarie drodarie changed the title refactor!: mpi hdf5 refactor: mpi hdf5! Dec 29, 2024
@github-actions github-actions bot added refactor and removed fix labels Dec 29, 2024
@drodarie drodarie changed the title refactor: mpi hdf5! refactor!: mpi hdf5 Dec 29, 2024
@drodarie drodarie merged commit 575c9bd into main Jan 7, 2025
10 checks passed
@drodarie drodarie deleted the fix/mpi-hdf5 branch January 7, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading multiple time the same file with MPI
2 participants