-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: mpi hdf5 #36
Conversation
Neither this or the parent PR are fix PRs, they're a breaking change to the storage interface. Maybe this is a good time to include a dev doc in the public documentation that documents all the pieces of the Storage interface, and to see if there's other opportunities of stuff to rectify. I'd for sure make sure that all method signatures are sort of the same, and that all the methods are MPI aware (since that seemed to have been overlooked for some?) and have access to the communicator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is a breaking change, needs an extra moment to see if there's other problems
I do not understand why we do not simply clear the chunks' group in the hdf5 file when we clear their content. Is there a reason why they should not be removed for good? @handles_handles("a")
def clear(self, chunks=None, handle=HANDLED):
if chunks is None:
chunks = self.get_loaded_chunks()
for chunk in chunks:
del handle[self.get_chunk_path(chunk)] |
I don't recall, you can give it a go and see if anything breaks. |
Add MPILock to static methods to load hdf5 file.
Fix dbbs-lab/bsb-core#893
Needs dbbs-lab/bsb-core#902
Closes #16