update dbt_is_deleted to string #6749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
changed the title
nataliefiann
reviewed
Jan 9, 2025
website/docs/reference/resource-configs/snapshot_meta_column_names.md
Outdated
Show resolved
Hide resolved
mirnawong1
changed the title
github-actions
bot
added
size: medium
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mirnawong1
commented
Jan 9, 2025
mirnawong1
commented
Jan 9, 2025
|
|
||
| For the `timestamp` strategy, the configured `updated_at` column is used to populate the `dbt_valid_from`, `dbt_valid_to` and `dbt_updated_at` columns. | ||
| *The timestamps used for each column are subtly different depending on the strategy you use: |
There was a problem hiding this comment.
I think we should leave the * out unless it's used as an endnote/footnote somewhere else for reference. We could use language we use elsewhere like Note: or similar
Suggested change
| *The timestamps used for each column are subtly different depending on the strategy you use: | |
| The timestamps used for each column are subtly different depending on the strategy you use: |
There was a problem hiding this comment.
I thought the same but the asterisk is actually referenced in line 436, which is why I added it back it 😅
There was a problem hiding this comment.
I didn't even see that. Pretty easy to miss both ways and might want to consider removing both but doesn't need to block this PR
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
website/docs/reference/resource-configs/snapshot_meta_column_names.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Shaver <[email protected]>
matthewshaver
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates
dbt_is_deletedto string value, not boolean.updated snapshot and snashot-metadata-column-name page.
confirming with grace whether config description is correct
Resolves #6747
🚀 Deployment available! Here are the direct links to the updated files: