-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dbt_is_deleted to string #6749
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3a2ca97
update to string
mirnawong1 31be5a4
Merge branch 'current' into update-dbt-is-deleted
mirnawong1 2d92749
Merge branch 'current' into update-dbt-is-deleted
mirnawong1 b5fcb58
Merge branch 'current' into update-dbt-is-deleted
mirnawong1 7b58e26
fix meaning"
mirnawong1 07e2e2f
consolidate table
mirnawong1 108a416
test
mirnawong1 f47ea23
Update website/docs/docs/build/snapshots.md
mirnawong1 236a236
Update website/docs/docs/build/snapshots.md
mirnawong1 27680f7
Update snapshots.md
mirnawong1 cc6d8f9
Update snapshots.md
mirnawong1 2aa02f2
Update snapshot_meta_column_names.md
mirnawong1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave the * out unless it's used as an endnote/footnote somewhere else for reference. We could use language we use elsewhere like Note: or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the same but the asterisk is actually referenced in line 436, which is why I added it back it 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even see that. Pretty easy to miss both ways and might want to consider removing both but doesn't need to block this PR