add slack to enterprise table #6793
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
| @@ -33,6 +33,7 @@ Key: | |||
| | Project (create) | W | - | - | W | - | - | | |||
| | Public models | R | R | - | R | R | R | | |||
| | Service tokens | W | - | - | - | R | R | | |||
| | Slack notifications | W | - | - | - | - | - | | |||
There was a problem hiding this comment.
Hiya @mirnawong1
This is a non-blocking suggestion / question, would it be too much but would it be too much to link out the permissions under the "Account-level permission" section to their relevant pages?
Kind Regards
Natalie
There was a problem hiding this comment.
that's a good question and it was someting i was going to do for slack but probably one for @matthewshaver to address or maybe you can create a gh issue?
i guess some of of the areas a generic and might have multiple pages to address them?
There was a problem hiding this comment.
I don't think we want to add this to this table. We don't technically have a permission in code that is directly tied to slack notifications. The Account settings (write) permission in this table is what dictates whether a user can set up the Slack notifications.
There was a problem hiding this comment.
That's a good callout and it should be slack configuration. Maybe we can just add a note somewhere and remove it from the table since it's covered in account settings
| @@ -33,6 +33,7 @@ Key: | |||
| | Project (create) | W | - | - | W | - | - | | |||
| | Public models | R | R | - | R | R | R | | |||
| | Service tokens | W | - | - | - | R | R | | |||
| | Slack notifications | W | - | - | - | - | - | | |||
There was a problem hiding this comment.
I don't think we want to add this to this table. We don't technically have a permission in code that is directly tied to slack notifications. The Account settings (write) permission in this table is what dictates whether a user can set up the Slack notifications.
this pr adds the required permissions to configure Slack to the enterprise permissions table and page
Resolves #6772
🚀 Deployment available! Here are the direct links to the updated files: