Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slack to enterprise table #6793

Open
wants to merge 3 commits into
base: current
Choose a base branch
from
Open

add slack to enterprise table #6793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b5c51c
add slack to enterprise table
mirnawong1 Jan 17, 2025
dc8b792
Merge branch 'current' into add-slack-permission
mirnawong1 Jan 17, 2025
a20b913
Merge branch 'current' into add-slack-permission
mirnawong1 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/docs/docs/cloud/account-integrations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ Connect your dbt Cloud account to an OAuth provider that are integrated with dbt
To configure an OAuth account integration:
1. Navigate to **Account settings** in the side menu.
2. Under the **Settings** section, click on **Integrations**.
3. Under **OAuth**, and click on **Link** to connect your Slack account.
4. For custom OAuth providers, under **Custom OAuth integrations**, click on **Add integration** and select the OAuth provider from the list. Fill in the required fields and click **Save**.
3. Under **OAuth**, and click on **Link** to [connect your Slack account](/docs/deploy/job-notifications#set-up-the-slack-integration).
4. For custom OAuth providers, under **Custom OAuth integrations**, click on **Add integration** and select the [OAuth provider](/docs/cloud/manage-access/sso-overview) from the list. Fill in the required fields and click **Save**.

<Lightbox src="/img/docs/dbt-cloud/account-integration-oauth.jpg" width="85%" title="Example of the OAuth integration page" />

Expand Down
1 change: 1 addition & 0 deletions website/snippets/_enterprise-permissions-table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Key:
| Project (create) | W | - | - | W | - | - |
| Public models | R | R | - | R | R | R |
| Service tokens | W | - | - | - | R | R |
| Slack notifications | W | - | - | - | - | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

This is a non-blocking suggestion / question, would it be too much but would it be too much to link out the permissions under the "Account-level permission" section to their relevant pages?

Kind Regards
Natalie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good question and it was someting i was going to do for slack but probably one for @matthewshaver to address or maybe you can create a gh issue?

i guess some of of the areas a generic and might have multiple pages to address them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add this to this table. We don't technically have a permission in code that is directly tied to slack notifications. The Account settings (write) permission in this table is what dictates whether a user can set up the Slack notifications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good callout and it should be slack configuration. Maybe we can just add a note somewhere and remove it from the table since it's covered in account settings

| Webhooks | W | - | - | - | - | - |
`}

Expand Down
Loading