removed IOX_INTERNAL_MAX_NUMBER_OF_NOTIFIERS made IOX_MAX_NUMBER_OF_N…

[niclar]

…OTIFIERS configurable again

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes configurable IOX_MAX_NUMBER_OF_NOTIFIERS #2083

[elBoberido]

@niclar looks good. Just a little formalism is still missing.

Could you please

• change the commit message from removed ... to iox-#2083 Remove ...
• add an entry in the refactoring part of the changelog

When this is done, there is nothing which prevents this PR to be merged

[codecov]

Codecov Report

Merging #2090 (b40502d) into master (1ac5726) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   80.30%   80.29%   -0.01%     
==========================================
  Files         417      417              
  Lines       16132    16132              
  Branches     2253     2253              
==========================================
- Hits        12954    12953       -1     
  Misses       2384     2384              
- Partials      794      795       +1     

Flag	Coverage Δ
unittests	80.08% <ø> (-0.01%)	⬇️
unittests_timing	15.29% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[elBoberido]

There is a bugfix for the failing test on Arch Linux. Could you rebase to master when you apply the fix to the changelog?

[elBoberido]

Oh, it seems in the BUILD.bazel file the tab needs to be replaced with spaces

[elBoberido]

@niclar looks good now. Had to do a merge with master and should be merged once the CI passes. Thanks for your contribution.