Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2282 Prepare v2.0.6 release #2283

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 25, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.47%. Comparing base (13a38b5) to head (625b2d0).
Report is 5 commits behind head on release_2.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2283      +/-   ##
===============================================
- Coverage        78.47%   78.47%   -0.01%     
===============================================
  Files              370      370              
  Lines            14218    14217       -1     
  Branches          2061     2060       -1     
===============================================
- Hits             11158    11157       -1     
  Misses            2377     2377              
  Partials           683      683              
Flag Coverage Δ
unittests 77.70% <0.00%> (-0.01%) ⬇️
unittests_timing 15.12% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
iceoryx_dds/source/gateway/main.cpp 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-2282-prepare-v-2-0-6-release branch from 2b9df2b to a6e5ab8 Compare April 25, 2024 14:46
@elBoberido elBoberido force-pushed the iox-2282-prepare-v-2-0-6-release branch from a6e5ab8 to d8171ca Compare April 25, 2024 14:48
@elBoberido elBoberido requested a review from mossmaurice April 25, 2024 14:49
@elBoberido elBoberido force-pushed the iox-2282-prepare-v-2-0-6-release branch from d8171ca to dd485f1 Compare April 25, 2024 15:14
@elBoberido elBoberido linked an issue Apr 25, 2024 that may be closed by this pull request
@elBoberido elBoberido force-pushed the iox-2282-prepare-v-2-0-6-release branch 2 times, most recently from da15631 to ab9286a Compare April 25, 2024 15:45
@elBoberido elBoberido force-pushed the iox-2282-prepare-v-2-0-6-release branch from ab9286a to ba029a7 Compare April 25, 2024 15:50
@elBoberido
Copy link
Member Author

elBoberido commented Apr 25, 2024

ROS2 CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of the release!

@elBoberido
Copy link
Member Author

@clalancette the aarch64 builds are marked as unstable. I'm quite sure it is not related to the changes of this PR and would create the release nevertheless

@elBoberido elBoberido linked an issue Apr 25, 2024 that may be closed by this pull request
@elBoberido
Copy link
Member Author

@mossmaurice it seems the approval was not discarded after updating the release date in the release notes

Re-triggered the ROS2 CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@elBoberido
Copy link
Member Author

@clalancette all the failed tests on aarch64 yesterday had this error message

mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'

This is not related in any way to iceoryx and if the current run will have the same failures I'll merge this branch and create the release

@elBoberido elBoberido force-pushed the iox-2282-prepare-v-2-0-6-release branch from 2671ba1 to 625b2d0 Compare April 26, 2024 12:58
@clalancette
Copy link
Contributor

This is not related in any way to iceoryx and if the current run will have the same failures I'll merge this branch and create the release

Yes, that's correct. That's a known issue that we are tracking separately: ros2/Mimick#35

@elBoberido elBoberido merged commit 69ec978 into release_2.0 Apr 26, 2024
14 checks passed
@elBoberido elBoberido deleted the iox-2282-prepare-v-2-0-6-release branch April 26, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warnings on latest macOS on release_2.0 Prepare v2.0.6 release for ROS2
3 participants