Skip to content

Move Pair containers to sequence storage - #983

Draft
ezrosent wants to merge 1 commit into
codex/inline-containers-09-multisetfrom
codex/inline-containers-10-pair
Draft

ezrosent wants to merge 1 commit into
codex/inline-containers-09-multisetfrom
codex/inline-containers-10-pair

Conversation

@ezrosent

@ezrosent ezrosent commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Encode pairs as [rebuild mask, first, second].
  • Construct and project pairs directly through the sequence representation.
  • Rebuild only the lanes selected by the pair mask.
  • Cover round trips, selective and unchanged rebuilds, and execution-local predictions.

Stack

Draft, stacked on #982. This is PR 10 of 12 in the sequence-backed container stack.

Validation

Validated on the complete 12-commit stack:

  • cargo nextest run --workspace: 1,362 tests passed
  • cargo test --workspace --doc
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo fmt --all -- --check

@codecov-commenter

codecov-commenter commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.78744% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.88%. Comparing base (2b4d183) to head (729c201).

Files with missing lines Patch % Lines
src/sort/pair.rs 91.78% 17 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           codex/inline-containers-09-multiset     #983      +/-   ##
=======================================================================
- Coverage                                88.01%   87.88%   -0.14%     
=======================================================================
  Files                                      103      103              
  Lines                                    39364    39568     +204     
=======================================================================
+ Hits                                     34645    34773     +128     
- Misses                                    4719     4795      +76     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 37 untouched benchmarks
⏩ 227 skipped benchmarks1


Comparing codex/inline-containers-10-pair (729c201) with codex/inline-containers-09-multiset (2b4d183)

Open in CodSpeed

Footnotes

  1. 227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from 7cdb234 to 959c15a Compare August 6, 2026 05:34
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from 959c15a to e4f8ea6 Compare August 10, 2026 05:20
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from e4f8ea6 to a747635 Compare August 10, 2026 05:53
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch 2 times, most recently from 13ba7e1 to ea8683e Compare August 10, 2026 06:54
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from ea8683e to b3680af Compare August 11, 2026 01:30
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from b3680af to 83fd99b Compare August 14, 2026 04:37
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch 2 times, most recently from 923bc3e to 766ff55 Compare August 14, 2026 05:02
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from 766ff55 to 9999f16 Compare August 14, 2026 05:04
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from 9999f16 to 04678d5 Compare August 14, 2026 05:09
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from 04678d5 to 14d26b8 Compare August 14, 2026 05:15
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from 14d26b8 to d37a386 Compare September 16, 2026 04:35
@ezrosent
ezrosent removed this pull request from stack #989 September 16, 2026 04:35
@ezrosent
ezrosent added this pull request to stack #1025 September 16, 2026 04:36
@ezrosent
ezrosent force-pushed the codex/inline-containers-10-pair branch from d37a386 to 729c201 Compare September 18, 2026 05:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants