Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the check for the "Build results" output? #563

Closed
mikeage opened this issue Aug 26, 2023 · 3 comments
Closed

Disabling the check for the "Build results" output? #563

mikeage opened this issue Aug 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@mikeage
Copy link

mikeage commented Aug 26, 2023

Context

We use a custom build action, and it doesn't print the same format of "Build results" that the default build method does. As a result, we're told that our build fails, even when it actually succeeds.

Suggested solution

Add an option to disable this check.

Considered alternatives

Adding this game-ci specific print to our build method.

Additional details

Raised on discord at https://discord.com/channels/710946343828455455/1143838569220280321

@AndrewKahr
Copy link
Member

Try updating to v4 and see if this is solved now

@mikeage
Copy link
Author

mikeage commented Nov 15, 2023

Unfortunately, v4 broke our flow for building from forks (where we had a license baked in to the github file, since secrets are inaccessible), and I'm not sure if the proper fix is to put a username/password there too. I've asked on the Discord (https://discord.com/channels/710946343828455455/1174438356755697784/1174438356755697784) and once this is resolved, I'll be able to see if our PR at icosa-foundation/open-brush#557 works.

@mikeage
Copy link
Author

mikeage commented Nov 21, 2023

Indeed, this works now. Thanks

@mikeage mikeage closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants