Feat: Add native SDK information in the replay option event

[brustolin]

📜 Description

Added cocoa name and version in the session replay options event for easy investigation.

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• I updated the wizard if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4a4126a

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1236.84 ms	1256.41 ms	19.56 ms
Size	22.31 KiB	761.40 KiB	739.08 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
dd4145f	1233.48 ms	1254.35 ms	20.88 ms
6604dbb	1248.35 ms	1256.14 ms	7.79 ms
b4f8dba	1343.92 ms	1362.96 ms	19.04 ms
a0cc9d6	1232.37 ms	1249.55 ms	17.18 ms
3cba0e8	1250.86 ms	1258.39 ms	7.53 ms
fa38a2b	1217.92 ms	1235.52 ms	17.60 ms
728804f	1341.16 ms	1371.27 ms	30.10 ms
bef2003	1248.18 ms	1258.86 ms	10.68 ms
7f14650	1236.00 ms	1255.66 ms	19.66 ms
b9b0f0a	1251.45 ms	1257.86 ms	6.41 ms

App size

Revision	Plain	With Sentry	Diff
dd4145f	21.58 KiB	540.09 KiB	518.51 KiB
6604dbb	22.84 KiB	402.56 KiB	379.72 KiB
b4f8dba	21.58 KiB	614.87 KiB	593.29 KiB
a0cc9d6	21.58 KiB	706.46 KiB	684.88 KiB
3cba0e8	22.84 KiB	403.19 KiB	380.34 KiB
fa38a2b	21.58 KiB	418.70 KiB	397.12 KiB
728804f	22.85 KiB	411.75 KiB	388.91 KiB
bef2003	22.85 KiB	407.73 KiB	384.88 KiB
7f14650	22.84 KiB	402.63 KiB	379.78 KiB
b9b0f0a	20.76 KiB	434.94 KiB	414.18 KiB

Previous results on branch: feat/sdk-info-sr-tags

Startup times

Revision	Plain	With Sentry	Diff
b7ac501	1230.59 ms	1253.66 ms	23.07 ms
37adb91	1240.06 ms	1261.49 ms	21.43 ms
7cdca55	1240.24 ms	1256.24 ms	16.00 ms
32a98c1	1227.61 ms	1252.87 ms	25.26 ms

App size

Revision	Plain	With Sentry	Diff
b7ac501	22.32 KiB	761.95 KiB	739.63 KiB
37adb91	22.31 KiB	761.39 KiB	739.08 KiB
7cdca55	22.32 KiB	761.54 KiB	739.22 KiB
32a98c1	22.32 KiB	762.11 KiB	739.79 KiB

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.670%. Comparing base (c5fef16) to head (4a4126a).

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4663       +/-   ##
=============================================
+ Coverage   90.631%   90.670%   +0.038%     
=============================================
  Files          621       621               
  Lines        71153     71191       +38     
  Branches     25310     25936      +626     
=============================================
+ Hits         64487     64549       +62     
+ Misses        6574      6545       -29     
- Partials        92        97        +5     

Files with missing lines	Coverage Δ
Sources/Sentry/SentryMeta.m	72.727% <100.000%> (+22.727%)	⬆️
.../SessionReplay/RRWeb/SentryRRWebOptionsEvent.swift	100.000% <100.000%> (ø)
...tegrations/SessionReplay/SentryReplayOptions.swift	95.000% <100.000%> (+0.084%)	⬆️
...tegrations/SessionReplay/SentrySessionReplay.swift	97.619% <100.000%> (+0.009%)	⬆️
...tions/SessionReplay/SentrySessionReplayTests.swift	99.111% <100.000%> (+0.041%)	⬆️

... and 19 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5fef16...4a4126a. Read the comment docs.

[philprime]

LGTM

[romtsn]

we should also set the same sdkInfo to the envelope header, which this replay event is a part of. And from what I see we don't set this sdkInfo to the default global one when initialized, which means we'll nullify the sdk context if we're not running on a hybrid SDK, right? @philprime @philipphofmann could you guys do that or should I take care while Dhiogo is out?

[philprime]

Not sure if I know how to do that yet, would be great if you or @philipphofmann can do it, with me reviewing the changes so I know afterwards.

[philipphofmann]

I'm confused by this PR; see #4663 (review).

[philipphofmann]

I will try to align this PR with how we do this in Java:

• https://github.com/getsentry/sentry-java/pull/4014/files#diff-368c74c6e2f2e3bc57f8d51fea2db766c2455714eba6d4fe40656cbfc1b50855
• https://github.com/getsentry/sentry-java/pull/4015/files#diff-c3475688f47a9611d7c966a91d999cc7c1d642b9bb16cd3223aed5722ec0608bR38-R42

[philipphofmann]

This is PR highly confusing to me. The SentryMeta sdkName and SDKVersion can be changed, and only SR events would use the nativeVersionString and nativeSDKName. All other Sentry data uses the SentryMeta sdkName and sdkVersion. @romtsn, do you use a similar approach on Android? If yes, what are the reasons for that?

[philipphofmann]

m: It's a good practice to do this check to avoid getting called multiple times in case we ever subclass this, see https://developer.apple.com/documentation/objectivec/nsobject/1418639-initialize.

if (self == [SentryMeta class]) {

}

[philipphofmann]

m: We should set the intial value to the values of the SentryMeta.

[philipphofmann]

m: We should use SentrySDKInfo here, convert it to Swift, and make it public. That's also how Android does it. Unfortunately, that's not trivial.

[github-actions]

• 🚫 The changelog entry seems to be part of an already released section ## 8.43.0.
  Consider moving the entry to the ## Unreleased section, please.