Repository navigation
fix(security): require patched Node 24 runtime for lambda images - #81
Merged
Merged
Conversation
imperfect-fourth
marked this pull request as ready for review
October 22, 2026 11:12
imperfect-fourth
requested review from
daniel-chambers and
shahidhk
and removed request for
daniel-chambers
October 22, 2026 11:12
imperfect-fourth
enabled auto-merge (squash)
October 22, 2026 11:18
| && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_24.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list \ | ||
| && apt-get update \ | ||
| && apt-get install -y nodejs \ | ||
| && node -e 'if (Number(process.versions.node.split(".")[0]) !== 24) process.exit(1)' \ |
Contributor
There was a problem hiding this comment.
Surely we want 24 or above rather than only accepting Node 24?
| && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_24.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list \ | ||
| && apt-get update \ | ||
| && apt-get install -y nodejs \ | ||
| && node -e 'if (Number(process.versions.node.split(".")[0]) !== 24) process.exit(1)' \ |
Contributor
There was a problem hiding this comment.
Suggested change
| && node -e 'if (Number(process.versions.node.split(".")[0]) !== 24) process.exit(1)' \ | |
| && node -e 'if (Number(process.versions.node.split(".")[0]) < 24) process.exit(1)' \ |
Something like this?
| packages = [ | ||
| pkgs.nixfmt | ||
| pkgs.nodejs_20 | ||
| pkgs.nodejs_24 |
Contributor
There was a problem hiding this comment.
Yeah this is the way
danieljharvey
approved these changes
Oct 26, 2026
6 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
node_24.xstays unpinned, as on main).ca-certificatespackage floor in the image build..nvmrcbumped fromlts/iron(Node 20) tolts/krypton(latest Node 24 LTS) so CI/dev track the same line as the image runtime.@hasura/ndc-sdk-typescriptbumped to^8.5.1(pulls@grpc/grpc-js1.14.6)..mocharc.jsonsets--no-experimental-strip-types, since Node 24's native type stripping intercepts ts-node in the mocha loader (angle-bracket assertions fail). Connector runtime is unaffected (verified: a function using enums + angle-bracket assertions serves correctly on Node 24.22.1 without the flag), so no image-wideNODE_OPTIONS.nodejs_20->nodejs_24andflake.lockupdated. nixpkgs has 24.21.0 for now, so the dev shell does not have the TLS fix yet. Runnix flake updateagain once nixpkgs ships 24.22.1.No change to
@hasura/ndc-lambda-sdkenginesor the template'snode >=20; npm consumers are unaffected.Validation
npm ci, build, 122 SDK tests passing.Follow-ups
Incident: https://emudhra.we-have-a-problem.com/