Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update game-ci build to v4 #557

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented Nov 15, 2023

Fixes Unity activation, which has been broken on the Unity side.

However, this does not currently support builds from PRs from forks. We now need to pass a username & password as well as a license file if we use a personal license, which we do for builds from forks, since forks can't access the secrets where we store our Pro license.

Sample showing that it builds: https://github.com/icosa-foundation/open-brush/actions/runs/6930830858

@mikeage mikeage added the infrastructure Build or tooling infrastructure label Nov 15, 2023
@mikeage mikeage self-assigned this Nov 15, 2023
@mikeage mikeage merged commit 2f5d7a7 into icosa-foundation:main Nov 20, 2023
10 of 20 checks passed
@mikeage mikeage deleted the new_ci_action branch November 20, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build or tooling infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant