Use the Home+Control /setstate API to modify room heating if home has a BNS #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use _async_therm_set instead of _async_set_thermpoint if the home has a BNS (Smarther with Netatmo thermostat)
fabianocattaneo
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @fabianocattaneo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
cgtobi
previously approved these changes
Aug 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
cgtobi
previously approved these changes
Aug 18, 2024
cgtobi
reviewed
Aug 18, 2024
cgtobi
reviewed
Aug 18, 2024
cgtobi
reviewed
Aug 18, 2024
cgtobi
reviewed
Aug 18, 2024
cgtobi
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Home+Control /setstate API (instead of /setroomthermpoint Energy API) to modify room heating if home has a BNS (Smarther with Netatmo thermostat)