Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Home+Control /setstate API to modify room heating if home has a BNS #496

Merged
merged 6 commits into from
Aug 18, 2024
Merged

Use the Home+Control /setstate API to modify room heating if home has a BNS #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa5469a
Added function to check if any room has a BNS device
fabianocattaneo Apr 25, 2024
6e46b16
Use _async_therm_set instead if home has a BNS
fabianocattaneo Apr 25, 2024
b8b64b3
Update src/pyatmo/home.py
cgtobi Aug 18, 2024
9c5946c
Update src/pyatmo/home.py
cgtobi Aug 18, 2024
73cbc1f
Update src/pyatmo/room.py
cgtobi Aug 18, 2024
858d8c2
Update src/pyatmo/room.py
cgtobi Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/pyatmo/home.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ def has_otm(self) -> bool:

return any("OTM" in room.device_types for room in self.rooms.values())

def has_bns(self) -> bool:
"""Check if any room has a BNS device."""
cgtobi marked this conversation as resolved.
Show resolved Hide resolved

return any("BNS" in room.device_types for room in self.rooms.values())
fabianocattaneo marked this conversation as resolved.
Show resolved Hide resolved

def get_hg_temp(self) -> float | None:
"""Return frost guard temperature value for given home."""

Expand Down
4 changes: 3 additions & 1 deletion src/pyatmo/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ async def async_therm_set(
mode = MODE_MAP.get(mode, mode)

if "NATherm1" in self.device_types or (
"NRV" in self.device_types and not self.home.has_otm()
"NRV" in self.device_types
and not self.home.has_otm()
and not self.home.has_bns()
):
await self._async_set_thermpoint(mode, temp, end_time)

Expand Down