Provide minimal test for whereabouts, along with successful vendor of the net-attach-def client for k8s 1.22 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
force-pushed
the
vendor-nad-stuff-along-with-minimal-test
branch
3 times, most recently
from
e84a760 to
13794f7
Compare
maiqueb
changed the title
Pull Request Test Coverage Report for Build 1910049182
💛 - Coveralls |
maiqueb
force-pushed
the
vendor-nad-stuff-along-with-minimal-test
branch
4 times, most recently
from
f743322 to
a11cacb
Compare
nicklesimba
reviewed
Feb 23, 2022
maiqueb
force-pushed
the
vendor-nad-stuff-along-with-minimal-test
branch
2 times, most recently
from
8953a49 to
4af5833
Compare
nicklesimba
reviewed
Feb 23, 2022
There was a problem hiding this comment.
LGTM, @dougbtv can you give this a pass when you get a chance as well?
Merged
Closed
dougbtv
approved these changes
Feb 24, 2022
pkg/config/config.go
Outdated
| if n.CNIVersion == v { | ||
| return fmt.Errorf("CNI version %v does not support more than 1 address per family", n.CNIVersion) | ||
| } | ||
| if isSupportedVersion, _ := version.GreaterThanOrEqualTo(n.CNIVersion, minimumSupportedVersion); !isSupportedVersion { |
|
|
||
| // WaitForPodBySelector waits up to timeout seconds for all pods in 'namespace' with given 'selector' to enter provided state | ||
| // If no pods are found, return nil. | ||
| func WaitForPodBySelector(cs *kubernetes.Clientset, namespace, selector string, timeout int) error { |
There was a problem hiding this comment.
Do we call this anywhere? We don't have to remove it, totally ok to have, just making sure I'm reading it correctly.
There was a problem hiding this comment.
Good catch! This was left in as part of the more complex e2e test that I'm working on. We can keep it in if it's not a big deal since it will get used eventually, but I'm okay with removing it, too.
maiqueb
force-pushed
the
vendor-nad-stuff-along-with-minimal-test
branch
from
b0210d4 to
e94f447
Compare
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: nicklesimba <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Pass the path to the kubeconfig, and cleanup some variables that are not in use. Also, ensure that the e2e tests are not executed when the `hack/test-go.sh` script is executed - that is for the unit tests only. Signed-off-by: Miguel Duarte Barroso <[email protected]>
This commit is an effort at improving the code readability, while preserving its functionality. It does: - provide properly scoped variables - adds some helper functions to improve readability - removes `Expect`ations from the helper functions - remove redundant comments - they're just one more thing to maintain - use receiver functions when appropriate (aka methods) Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
vendor-nad-stuff-along-with-minimal-test
branch
from
e94f447 to
9b0d073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on top of PR #196.