-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report back intent execution result #3132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@@ -124,6 +132,10 @@ pub mod pallet { | |||
pub type AccountStoreHash<T: Config> = | |||
StorageMap<Hasher = Blake2_128Concat, Key = T::AccountId, Value = H256>; | |||
|
|||
#[pallet::storage] | |||
#[pallet::getter(fn omni_executor)] | |||
pub type OmniExecutor<T: Config> = StorageValue<_, T::AccountId, OptionQuery>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use teebag
as the sole place to manage enclaves? I'm not sure if RA is ready for omni-executor though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw the TEECallOrigin
does go through the teebag storages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omni-executor is not registered as enclave at this moment
|
||
#[pallet::call_index(7)] | ||
#[pallet::weight((195_000_000, DispatchClass::Normal, Pays::No))] | ||
pub fn intent_executed( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think later we could have an enum representing the status of an Intent
, like:
Submitted,
Synced / ProcessStarted,
Finished,
self.legacy.chain_get_block_hash(Some(block_num.into())).await.map_err(|_| ())?; | ||
async fn get_raw_metadata(&mut self, block_num: Option<u64>) -> Result<Vec<u8>, ()> { | ||
let maybe_hash = self | ||
.legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what are non-legacy methods for such queries? 😲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's Metadata_metadata_at_version
Once CI and conflicts are resolved we are good to go |
No description provided.