Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binac.config #732

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Update binac.config #732

merged 1 commit into from
Aug 14, 2024

Conversation

fbartusch
Copy link
Contributor


name: binac config
about: update binac config

Please follow these steps before submitting your PR:

  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Sorry for the second pull request within a week. As @pontus pointed out in the last (already merged) /pull/728 request, setting a single global cacheDir is not ideal for security. I also added a libraryDir.

One cacheDir per User
Add libraryDir to config.
@fbartusch fbartusch requested a review from apeltzer as a code owner August 14, 2024 10:03
@apeltzer apeltzer merged commit 78cc73b into nf-core:master Aug 14, 2024
126 checks passed
@@ -8,7 +8,8 @@ params {

singularity {
enabled = true
cacheDir = '/beegfs/work/container/apptainer_cache'
libraryDir = '/beegfs/work/container/apptainer_library'
cacheDir = '/beegfs/work/container/apptainer_cache/$USER'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, have you tested this? My recollection is that nextflow isn't happy if you point it at an non-existing cache directory (and while it shouldn't be super hard, if it gets into setting up a system to create these, maybe it's not worth caring about if you knew what pipelines people would run and could pull those images into the library directory anyway).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextflow creates a non-existing cache directory. /beegfs/work/container/apptainer_cache/ still exists and Nextflow creates the $USERpart. I tested it by deleting my directory in the cache and running a pipeline from scratch. The pipeline recreates the directory.
But I made a big mistake by using single quotes, $USER doesn't get resolved and it creates a directory called $USER. A very embarrassing mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants