New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ood-gen) Adjust type of fields with `list option` type to `list` in Changelog, News, Planet, and Workshop #2042

Merged

sabine merged 11 commits into ocaml:main from egmaleta:list-opt-to-list-remaining-tasks

Feb 13, 2024

Contributor

egmaleta commented Feb 9, 2024

Removed option from type of fields:

Changelog.t.authors
News.t.authors
Planet.t.authors
Workshop.presentations.additional_links

This and #2039 might close #1970.

egmaleta added 5 commits

February 9, 2024 15:40


          remove option type from Changelog.t.authors

bf3f132


          remove option type from News.t.authors

5b8ee00


          remove option type from Workshop.presentation.additional_links

31384d1


          remove option type from Planet.t.authors

49f391e


          use Option.value instead of pattern matching

1eae442

egmaleta changed the title ~~Replace list option by list in remaining task of #1970~~ Replace list option by list in remaining tasks of #1970

sabine changed the title ~~Replace list option by list in remaining tasks of #1970~~ (ood-gen) Adjust type of fields with list option type to list in remaining tasks of #1970

cuihtlauac mentioned this pull request

Replace bool option by bool in data #2051

Closed

3 tasks

cuihtlauac requested changes

View reviewed changes

tool/ood-gen/lib/workshop.ml Outdated Show resolved Hide resolved

tool/ood-gen/lib/news.ml Show resolved Hide resolved

tool/ood-gen/lib/changelog.ml Show resolved Hide resolved


          Apply suggestions from code review

073e05c

cuihtlauac requested changes

View reviewed changes

tool/ood-gen/lib/workshop.ml Outdated Show resolved Hide resolved


          Update tool/ood-gen/lib/workshop.ml

ecfc594

cuihtlauac requested changes

View reviewed changes

tool/ood-gen/lib/news.ml Outdated Show resolved Hide resolved


          Update tool/ood-gen/lib/news.ml

b0b9ee2

cuihtlauac requested changes

View reviewed changes

tool/ood-gen/lib/changelog.ml Outdated Show resolved Hide resolved

tool/ood-gen/lib/changelog.ml Outdated Show resolved Hide resolved


          Apply suggestions from code review

3efc257

cuihtlauac requested changes

View reviewed changes

src/ocamlorg_frontend/pages/blog_post.eml Outdated Show resolved Hide resolved

tool/ood-gen/lib/workshop.ml Outdated Show resolved Hide resolved

egmaleta added 2 commits

February 13, 2024 07:49


          render i tag only if authors field is non-empty

a8a2463


          revert: remove option type from Workshop.presentation.additional_links

0b289cd

Contributor Author

egmaleta commented Feb 13, 2024

I am sorry i marked the requested changes as resolved before I actually resolve them, my bad.

Regarding the task in workshop.ml, what can be done there instead of using an additional presentation type with option type removed from fields and a transformation function to create the records with this new type?

cuihtlauac approved these changes

View reviewed changes

Collaborator

cuihtlauac left a comment

This looks good to me. Thanks @egmaleta

sabine changed the title ~~(ood-gen) Adjust type of fields with list option type to list in remaining tasks of #1970~~ (ood-gen) Adjust type of fields with list option type to list in Changelog, News, Planet, and Workshop

sabine approved these changes

View reviewed changes

Collaborator

sabine left a comment

Thanks @egmaleta! Merging! ✨ 👍

sabine merged commit d662834 into ocaml:main

3 checks passed

This was referenced Feb 13, 2024

(ood-gen) Adjust type of fields with bool option type to bool in Release #2055

Merged

(ood-gen) Adjust type of fields with option type in Workshop #2068

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet