Enabled clang-tidy checks in header files #2338
Open
+138
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
asimonov1
reviewed
Jan 5, 2025
|
We could temporarily add another non blocking check that checks for warnings in the headers, and allow the current one to remain while we fix them. |
|
Also, 3p should ideally be in a separate folder anyways. |
rjoursler
reviewed
Jan 6, 2025
vpirogov
force-pushed
the
vpirogov/clang-tidy-fix
branch
from
b3db2ee to
c12dde1
Compare
github-actions
bot
added
the
documentation
mgouicem
reviewed
Jan 8, 2025
vpirogov
force-pushed
the
vpirogov/clang-tidy-fix
branch
2 times, most recently
from
b41a9f9 to
9f692ba
Compare
github-actions
bot
added
component:api
vpirogov
force-pushed
the
vpirogov/clang-tidy-fix
branch
from
9f692ba to
d14cbe6
Compare
github-actions
bot
removed
the
component:graph-api
vpirogov
force-pushed
the
vpirogov/clang-tidy-fix
branch
from
d14cbe6 to
29a4258
Compare
Leading underscore was a legacy of ancient clang
Structure names in oneDNN public API do not include `_t` suffix and upset clang-tidy.
This preserves previous behavior in CI. New CHECK_ALL option enables clang-tidy in both headers and source.
vpirogov
force-pushed
the
vpirogov/clang-tidy-fix
branch
from
29a4258 to
122c4d9
Compare
|
make test |
|
make test Lightweight_scans |
1 similar comment
|
make test Lightweight_scans |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current setup does not run any clang-tidy check on header files. One wrinkle is that we don't want it to touch any header files from third party components embedded in the source code, but current version of clang-tidy does not offer a way to exclude these. There are couple options:
ExcludeHeaderFilterRegexoption available in clang-tidy >=19.0/third-party) (in this PR)With these changes CI will continue to scan source code only to avoid noise. Scan for headers will be available with
ONEDNN_USE_CLANG_TIDY=CHECK_ALLoption or manualclan-tidyinvocation. With that we have 1390 unique warnings for Intel CPU/GPU build.Related to MFDNN-12943.