[chore] Clarify config removal in CONTRIBUTING.md #10582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that deprecated config options are expected to remain for at least 6 months after deprecation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10582 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 406 406
Lines 18947 18947
=======================================
Hits 17378 17378
Misses 1209 1209
Partials 360 360 ☔ View full report in Codecov by Sentry. |
crobert-1
approved these changes
Jul 10, 2024
atoulme
approved these changes
Jul 13, 2024
andrzej-stencel
approved these changes
Jul 16, 2024
codeboten
approved these changes
Jul 16, 2024
atoulme
added
the
ready-to-merge
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
approved these changes
Aug 13, 2024
|
cc @open-telemetry/collector-approvers will merge by |
songy23
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify that deprecated config options are expected to remain for at least 6 months after deprecation.
"MUST NOT" makes it clear for readers that this is something that definitely should not be done, vs. something that's discretionary.
See also open-telemetry/opentelemetry-collector-contrib#33776 (comment)