Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Clarify config removal in CONTRIBUTING.md #10582

Merged
merged 2 commits into from
Aug 16, 2024
Merged

[chore] Clarify config removal in CONTRIBUTING.md #10582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d33dfac
[chore] Clarify config removal in CONTRIBUTING.md
axw Jul 10, 2024
5d111af
Merge branch 'main' into contributing-option-removal
axw Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ When renaming or removing a configuration option:
- a WARN level message should be logged, with a link to a place within the component's repository where the change is
documented and a migration path is provided
- the option MUST be kept for at least N+1 version and MAY be hidden behind a feature gate in N+2
- the option and the WARN level message MAY be removed after N+2 or 6 months, whichever comes later
- the option and the WARN level message MUST NOT be removed earlier than N+2 or 6 months, whichever comes later

Additionally, when removing an option:
- the option MAY be made non-operational already by the same version where it is deprecated
Expand Down
Loading