NO-JIRA: Finish Alerting Refactor #306
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
PeterYurkovich
changed the title
|
@PeterYurkovich: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/retest |
|
Don't worry about retesting this PR for now, as the tests will likely need to be rerun regardless in the new year |
|
/retest |
|
@juzhao could you please check this PR for regressions? |
|
@PeterYurkovich: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold
Since OU-561 was completed without finishing the refactor, this PR looks to finalize the Alerting refactor. Pulling out the final two pages into their own files, and removing the routing entrypoint of the monitoring UI from the alerting.tsx file to a new router.tsx file.
We should hold this PR until everyone is back in January