Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Michelin and Pirelli #10346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ckpiper
Copy link
Collaborator

@ckpiper ckpiper commented Jan 14, 2025

Both of these brands do not have physical locations. Thus, I am wondering if it even makes sense to have them in NSI. Yes they are brands, but the point of NSI is to have common brand names for Places. Then POIs in OSM will have matching common names if they are the same company stores. Am I thinking about this correctly?

@bhousel
Copy link
Member

bhousel commented Jan 14, 2025

Both of these brands do not have physical locations. Thus, I am wondering if it even makes sense to have them in NSI. Yes they are brands, but the point of NSI is to have common brand names for Places. Then POIs in OSM will have matching common names if they are the same company stores. Am I thinking about this correctly?

You are correct - we really only want to have brands with physical locations that should be mapped in OSM.

However I checked the Overpass queries on this page:
https://nsi.guide/index.html?t=brands&k=shop&v=tyres

...and I can see that for both these brands there are a lot of places in OpenStreetMap mapped like shop=tyres+name=Michelin or name=Pirelli

So maybe you're mistaken, or maybe these shops really are all mapped wrongly - I do not know.

But what it means is that even if we do delete these entries, our script that loads names from the OSM data will just put them back, because as far as the script is concerned they seem to be real names of tyre shops.

@Oivo35
Copy link

Oivo35 commented Jan 14, 2025

I looked at the objects that have website and most of them are tagged incorrectly. These stores only sell Michelin and Pirelli tyres. So they should have the name of the stores.
And I also found a store in Australia called Michelin, so maybe for some stores the tags name=Michelin + brand=Michelin are correct.

@Snowysauce Snowysauce added needs research fix data Need to cleanup the data in OSM after this is released labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix data Need to cleanup the data in OSM after this is released needs research
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants