Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian packaging #169

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Debian packaging #169

wants to merge 34 commits into from

Conversation

regularfry
Copy link

This set of patches adds a very basic debian package definition. The package installs to /usr rather than /usr/local, and puts the documentation in the right place.

There are a couple of minor tweaks to the Makefile necessary to get this to be smooth: firstly, the debian helper scripts expect the Makefile to respect the DESTDIR environment variable, which I've added. Secondly, the helper scripts install the docs themselves, and don't rely on the make install task to do it for them. This means that before I split the make install task out to make install_files, I was getting two sets of documents installed, which was a little untidy.

The package installs and works on Debian Wheezy. I haven't tried it on an Ubuntu, but I think it should work without modification.

@postmodern
Copy link
Owner

Spoke with someone more knowledgeable of Debian Packaging. It shouldn't be necessary to split the install task. It's ok if dh_installdocs re-installs any documentation. DESTDIR stuff looks good.

@regularfry
Copy link
Author

Sorry, I'm not sure I understand. dh_installdocs installs the documentation to /usr/share/doc/chruby/, which is the "right" place according to Debian. make install installs them to /usr/share/doc/chruby-0.3.6/. If I disable dh_installdocs, I only get docs in the wrong place, and if I don't, I get both sets.

Would it be better to let Makefile's DOC_DIR get overridden by an environment variable to put them in Debian's preferred location?

@postmodern
Copy link
Owner

Ah ha. It looks like I used the RedHat style of DOC_DIR (name-version). Yeah, let's make DOC_DIR configurable and default it to PREFIX/share/doc/NAME.

bmalex and others added 24 commits July 6, 2013 17:59
@bmalex
Restore the full make install task
4f2a2c0 
In order not to duplicate the documentation, this patch makes the
DOC_DIR variable overridable by environment variable, and changes the
default path *not* to include the version number.
@postmodern
Version bump to 0.4.0.
9af4923
@postmodern
Also export RUBY_PATCHLEVEL (issue postmodern#62).
c77b750
@havenwood @postmodern
updated formatting and env descriptions
ec13525 
* Pulled in @havenwood's chruby man page.
@postmodern
Renamed chruby.md to chruby.1.md.
63dae6a
@postmodern
Moved docs/chruby.1 into share/man/man1/
09c6c3e
@postmodern
Added a basic man page task.
2c53469
@havenwood @postmodern
added -v, --version to OPTIONS
4f5e5ac
@havenwood @postmodern
Added chruby-exec(1) manpage to See Also section.
189861d
@havenwood @postmodern
remove doc/ from .gitignore
c284f63
@havenwood @postmodern
initial commit
b30d23e
@havenwood @postmodern
initial commit
fccdd41
@havenwood @postmodern
Added chruby-exec(1) duplicates of chruby(1) entries.
fbfb1ae
@postmodern
Use kramdown-man (https://github.com/postmodern/kramdown-man).
cf35adb
@havenwood @postmodern
Correct spelling typo.
23c18ec
@havenwood @postmodern
Correct spelling typo.
1adcb8a
@havenwood
Implement chruby-install as a function.
3e10495
@postmodern
Merge remote-tracking branch 'havenwood/chruby-install' into 0.4.0
8255155
@postmodern
Simply call chruby --version to avoid redefining CHRUBY_VERSION.
505a421
@postmodern
Use type -t to detect ruby-install.
4ad9316
@postmodern
Prefix error messages with the function name.
9b9535a
@postmodern
Print to stderr.
ea4cf1a
@postmodern
Style.
30b401e
@postmodern
If ruby-install is available, also print it's version.
3bd58f9
@postmodern postmodern mentioned this pull request Jul 23, 2013
Merged
@jnv
Copy link

jnv commented Apr 13, 2014

Bump; is there anything particular that prevents this PR from being merged?

@postmodern
Copy link
Owner

@jnv I believe just ensuring documentation is installed in the correct location. That and rebasing it against current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
debian
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@regularfry @postmodern @jnv @cbandy @bmalex @havenwood