Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested routes for systems #1213 #1217

Merged
merged 11 commits into from
Jan 9, 2025
Merged

Conversation

joshuadkitenge
Copy link
Collaborator

@joshuadkitenge joshuadkitenge commented Dec 20, 2024

Description

  • Create systems Layout for systems routes.
  • Re-design where move to and copy to are in system
  • This is going to be use for the hierarchy tree view
systems.mt.and.ct.mp4

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1213

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.95960% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.11%. Comparing base (eedfab6) to head (2101f0c).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
src/App.tsx 77.77% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1217      +/-   ##
===========================================
- Coverage    99.14%   99.11%   -0.04%     
===========================================
  Files           93       94       +1     
  Lines        17644    17641       -3     
  Branches      2954     2130     -824     
===========================================
- Hits         17494    17485       -9     
- Misses         146      155       +9     
+ Partials         4        1       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-system-#1213 branch 5 times, most recently from 9961061 to c49ed18 Compare December 20, 2024 16:48
@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-system-#1213 branch from c49ed18 to 7aac6ba Compare December 20, 2024 18:18
@joshuadkitenge joshuadkitenge marked this pull request as ready for review January 6, 2025 15:37
- manufacturer loader in the correct location
- Add scroll restoration react router
- add dev tool for react query
@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-admin-page-#1211 branch from ab3c84a to df29caf Compare January 8, 2025 16:31
@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-system-#1213 branch from 27c551f to b6345f9 Compare January 8, 2025 16:53
src/systems/systemsLayout.component.tsx Outdated Show resolved Hide resolved
src/systems/systemsLayout.component.tsx Outdated Show resolved Hide resolved
@joshuadkitenge joshuadkitenge force-pushed the nested-routes-for-system-#1213 branch from 9fe5a77 to 2101f0c Compare January 9, 2025 09:48
Base automatically changed from nested-routes-for-admin-page-#1211 to develop January 9, 2025 10:16
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new menu.

@joshuadkitenge joshuadkitenge merged commit e776262 into develop Jan 9, 2025
6 checks passed
@joshuadkitenge joshuadkitenge deleted the nested-routes-for-system-#1213 branch January 9, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested routes for systems
2 participants