Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #1239

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Fix flaky test #1239

merged 8 commits into from
Jan 13, 2025

Conversation

joshuadkitenge
Copy link
Collaborator

@joshuadkitenge joshuadkitenge commented Jan 9, 2025

Description

Add bundle analysis and flaky test detection

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Run the CI a couple of times

closes #1135

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (637ac22) to head (cb996a3).
Report is 9 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1239    +/-   ##
=========================================
  Coverage    99.10%   99.10%            
=========================================
  Files           94       94            
  Lines        17527    17527            
  Branches      2167     2978   +811     
=========================================
  Hits         17370    17370            
+ Misses         156      153     -3     
- Partials         1        4     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge force-pushed the fix-flaky-test branch 2 times, most recently from 1589a5c to 3a6289a Compare January 10, 2025 10:42
@joshuadkitenge joshuadkitenge force-pushed the fix-flaky-test branch 2 times, most recently from 16746a1 to c2575e5 Compare January 10, 2025 11:23
@joshuadkitenge joshuadkitenge marked this pull request as ready for review January 10, 2025 11:26
@joshuadkitenge joshuadkitenge marked this pull request as draft January 10, 2025 11:39
@joshuadkitenge joshuadkitenge removed the request for review from joelvdavies January 10, 2025 11:39
@joshuadkitenge joshuadkitenge marked this pull request as ready for review January 10, 2025 12:57
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests appear much more stable 🥳

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
cypress/e2e/with_mock_data/systems.cy.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
vite.config.ts Show resolved Hide resolved
vite.config.ts Show resolved Hide resolved
@joshuadkitenge joshuadkitenge merged commit 017b068 into develop Jan 13, 2025
7 checks passed
@joshuadkitenge joshuadkitenge deleted the fix-flaky-test branch January 13, 2025 11:38
@joelvdavies joelvdavies mentioned this pull request Jan 13, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codecov extra features
2 participants