Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manufacturer landing page #129 #132

Closed
wants to merge 11 commits into from

Conversation

MatteoGuarnaccia5
Copy link
Contributor

@MatteoGuarnaccia5 MatteoGuarnaccia5 commented Nov 13, 2023

Description

Manufacturer landing page which can be viewed by clicking on manufacturer's name in the table view. To be integrated with catalogue item table as well in future

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Check landing page renders correct data, and can be interacted with and edited accordingly
  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #129

@MatteoGuarnaccia5 MatteoGuarnaccia5 changed the title landing page logic #129 manufacturer landing page #129 Nov 14, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6309bc4) 92.22% compared to head (e0763d8) 92.30%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
+ Coverage    92.22%   92.30%   +0.07%     
===========================================
  Files           36       37       +1     
  Lines         2149     2170      +21     
  Branches       688      698      +10     
===========================================
+ Hits          1982     2003      +21     
  Misses         165      165              
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review November 16, 2023 09:20
@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as draft November 20, 2023 09:05
@MatteoGuarnaccia5 MatteoGuarnaccia5 marked this pull request as ready for review November 20, 2023 10:22
@MatteoGuarnaccia5
Copy link
Contributor Author

I merged this into #144 when I shouldn't have. So any requested changes I will address in #144. This PR I believe won't ever have to be merged in as it'll be in #144

@joelvdavies
Copy link
Collaborator

Superseded #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create manufacturer landing page
2 participants