Integrate manufacturer into catalogue items v2 #108

[MatteoGuarnaccia5]

Description

Integrated manufacturer into catalogue items, changed dialog so that users are able to select a manufacturer from a autocomplete dropdown. they can also add a new manufacturer, which will then be added to dropdown list. The ID of the manufacturer is then passed through to the backend to be added to the catalogue item. Currently the table view displays all the fields of a manufacturer (name, address ,url, telephone number) but this is subject to change based upon CLFs feedback

Note - #132 merged into this PR. So this PR will essentially close it and the issue for it

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage

Agile board tracking

closes #108
closes #129

[MatteoGuarnaccia5]

I tried to simplify the logic for selectedManufacturer in the Dialog. The solution I found doesn't seem to work when you then navigate to the landing page and try to edit an item from there. I can keep trying if you guys wish but it is as compact as I can make it

[joelvdavies]

I tried to simplify the logic for selectedManufacturer in the Dialog. The solution I found doesn't seem to work when you then navigate to the landing page and try to edit an item from there. I can keep trying if you guys wish but it is as compact as I can make it

If this is about the comment I made in catalogueItemsDialog, replacing
const { data: selectedCatalogueItemManufacturer } = useManufacturer( selectedCatalogueItem?.manufacturer_id );
with
const selectedCatalogueItemManufacturer = manufacturerList?.find( (manufactuerer) => manufactuerer.id === selectedCatalogueItem?.manufacturer_id ) || null;
appears to work. But don't worry about it if not.

[joelvdavies]

Last two things from me
The address on the manufacturers landing page is well spaced out

But on the catalogue items page it is not

There are also still a few ListItems in catalogueItemsLandingPage.component.tsx.

[joshuadkitenge]

The catalogue Item landing page styling needs to be same as what it was before but using typographys

Before:

After:

This styling will also need to carry through into the manufacturer landing page so that it looks similar to the catalogue items landing page

[joshuadkitenge]

Also, can you change how the manufacturer address is displayed so it matches what is in the table. below:

This format in both of the landing pages.

As currently the address is not in the most readable format

[MatteoGuarnaccia5]

Needs to be merged in first priority after christmas

[joshuadkitenge]

LGTM