remove unused 'joblib' and 'numba' dependencies, other packaging cleanup #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
jameslamb
changed the title
bdice
approved these changes
Dec 24, 2024
seberg
pushed a commit
to rapidsai/legate-raft
that referenced
this pull request
Dec 30, 2024
Came here looking to remove the `setup.cfg` file, inspired by rapidsai/raft#2532. But this PR uncovered a few other packaging things to be cleaned up. Proposes: * removing `Cython` dependency * aligning `cmake_minimum_required()` version with the one from the conda recipe, and with what RAPIDS has been using for the last few releases * removing `maptlolib` dependency for benchmarks ## Notes for Reviewers ### How is it safe to remove `Cython`? As far as I can tell, this project doesn't have any Cython code. It is building a shared library and then loading it with `ctypes`: https://github.com/rapidsai/legate-raft/blob/3260952df5cc09fe356ccf07e8832070f1029abb/legate_raft/library.py#L21-L26 Signed-off-by: James Lamb <[email protected]>
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Jan 7, 2025
Similar to rapidsai/raft#2532, this proposes some small packaging cleanup. * removes `setup.cfg` files - *these are currently being ignored by tools, in favor of identical configuration in `pyproject.toml` and `.flake8` files* - e.g. https://github.com/rapidsai/cuvs/blob/b3ce774d39e149d4e34c401068f24136eac44e13/.pre-commit-config.yaml#L31-L35 * alphabetizes dependency lists in `dependencies.yaml` * changes `cupy:` group in `dependencies.yaml` to `depends_on_cupy:` (for consistency with other dependencies) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Micka (https://github.com/lowener) URL: #544
cjnolet
approved these changes
Jan 7, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes some cleanup of packaging details, noticed while I was working on #2531
joblibandnumbaforraft-daskraft-daskdoesn't directly import from these libraries, and the git blame didn't suggest any other reason that they were being pinned heregit grep -E 'joblib|numba'setup.cfgfilespyproject.tomland.flake8filesraft/.pre-commit-config.yaml
Lines 16 to 19 in bfd1906